fix(admin): label mentor field "Mentor" not "Grad mentor" (#806)#1373
Merged
Conversation
) The mentor dropdown stopped being grad-only long ago — get_active_mentors_queryset already offers any active senior lab member (PhD/MS/postdoc/director/dev/designer/ research scientist), so a non-grad like a software developer can be selected. Only the admin label still read "Grad mentor", which was misleading. Set verbose_name='Mentor' so the label matches the behavior. The DB column is intentionally not renamed: this repo regenerates migrations non-interactively per environment, where a field rename can't be confirmed and would drop the column (the original blocker in #806). verbose_name fixes the label with no schema change. Co-mentor support (also floated in #806) is intentionally left out — no demand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #806.
Background
Issue #806 (2019) reported that non-grad members (e.g. a software developer like "Mikey") couldn't be selected as a "Grad Mentor", and proposed renaming the field to "Mentor" so any active member could be chosen. A co-mentor field was also floated.
What's actually true today
get_active_mentors_queryset()(website/admin/utils.py) populates the dropdown with any active senior lab member — PhD/MS students, postdocs, the director, software developers, designers, and research scientists — not just grad students. The original "can't select Mikey" complaint no longer applies.bio_utils.py), never "grad mentor".This PR
Sets
verbose_name='Mentor'onPosition.grad_mentorso the admin label reads "Mentor", matching the broadened behavior.The DB column is intentionally not renamed. This repo regenerates
website/migrations/non-interactively per environment; a field rename can't be confirmed at startup and would be applied as drop-column + add-column — i.e. data loss. That was the exact server-access blocker noted on #806 in 2019.verbose_nameis a state-only change with no schema impact, so it's safe to push.Co-mentor field: deliberately not added — no demonstrated demand.
Test
Adds
test_position_mentor_label.pypinningverbose_name == "Mentor"so the label can't silently regress. Passing locally.